Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for flat event kind #501

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

xJonathanLEI
Copy link
Owner

Fixes #499.

This is technically a breaking change, as we're adding a enum variant to EventFieldKind, but it would only break applications that exhaust all variants in a match expression, which I deem rather unlikely. If we want to make a release on top of 0.7.2 for this, I might just apply romantic versioning an make it a patch release as 0.7.3 instead of bumping minor to 0.8.0.

@milancermak
Copy link
Collaborator

No one is going to fault you for 0.7.3 I imagine, especially with the wild west versioning going on in the ecosystem 😁

@xJonathanLEI xJonathanLEI merged commit cfa3c43 into master Nov 8, 2023
24 checks passed
@xJonathanLEI xJonathanLEI deleted the dev/flat_event branch November 8, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for flat event
2 participants